linux-kernel - RE: [PATCH] arm: use memblocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM0PR04MB4481452226EC21AA7B90735288400@AM0PR04MB4481.eurprd04.prod.outlook.com>
Date:   Tue, 19 Mar 2019 12:06:26 +0000
From:   Peng Fan <peng.fan@....com>
To:     Russell King - ARM Linux admin <linux@...linux.org.uk>
CC:     "arnd@...db.de" <arnd@...db.de>,
        "rppt@...ux.vnet.ibm.com" <rppt@...ux.vnet.ibm.com>,
        "robh@...nel.org" <robh@...nel.org>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "mhocko@...e.com" <mhocko@...e.com>,
        "rostedt@...dmis.org" <rostedt@...dmis.org>,
        "nicolas.pitre@...aro.org" <nicolas.pitre@...aro.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "van.freenix@...il.com" <van.freenix@...il.com>
Subject: RE: [PATCH] arm: use memblocks_present

Hi Russell,

> -----Original Message-----
> From: Russell King - ARM Linux admin [mailto:linux@...linux.org.uk]
> Sent: 2019年2月13日 1:27
> To: Peng Fan <peng.fan@....com>
> Cc: arnd@...db.de; rppt@...ux.vnet.ibm.com; robh@...nel.org;
> f.fainelli@...il.com; akpm@...ux-foundation.org; mhocko@...e.com;
> rostedt@...dmis.org; nicolas.pitre@...aro.org;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
> van.freenix@...il.com
> Subject: Re: [PATCH] arm: use memblocks_present
> 
> On Mon, Feb 11, 2019 at 01:04:59PM +0000, Peng Fan wrote:
> > arm_memory_present is doing same thing as memblocks_present, so let's
> > use common code memblocks_present instead of platform specific
> > arm_memory_present.
> >
> > Signed-off-by: Peng Fan <peng.fan@....com>
> 
> Looks good, please put it in the patch system, thanks.  Details in my
> signature.

Would you apply this patch? I do not find this patch in your tree.

Thanks,
Peng.

> 
> > ---
> >  arch/arm/mm/init.c | 17 +----------------
> >  1 file changed, 1 insertion(+), 16 deletions(-)
> >
> > diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c index
> > 478ea8b7db87..6c50dd407ba8 100644
> > --- a/arch/arm/mm/init.c
> > +++ b/arch/arm/mm/init.c
> > @@ -182,21 +182,6 @@ int pfn_valid(unsigned long pfn)
> > EXPORT_SYMBOL(pfn_valid);  #endif
> >
> > -#ifndef CONFIG_SPARSEMEM
> > -static void __init arm_memory_present(void) -{ -} -#else -static void
> > __init arm_memory_present(void) -{
> > -	struct memblock_region *reg;
> > -
> > -	for_each_memblock(memory, reg)
> > -		memory_present(0, memblock_region_memory_base_pfn(reg),
> > -			       memblock_region_memory_end_pfn(reg));
> > -}
> > -#endif
> > -
> >  static bool arm_memblock_steal_permitted = true;
> >
> >  phys_addr_t __init arm_memblock_steal(phys_addr_t size, phys_addr_t
> > align) @@ -292,7 +277,7 @@ void __init bootmem_init(void)
> >  	 * Sparsemem tries to allocate bootmem in memory_present(),
> >  	 * so must be done after the fixed reservations
> >  	 */
> > -	arm_memory_present();
> > +	memblocks_present();
> >
> >  	/*
> >  	 * sparse_init() needs the bootmem allocator up and running.
> > --
> > 2.16.4
> >
> >
> 
> --
> RMK's Patch system:
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fww
> w.armlinux.org.uk%2Fdeveloper%2Fpatches%2F&amp;data=02%7C01%7Cpe
> ng.fan%40nxp.com%7Cb710ce9f14c942463c7b08d6910f548a%7C686ea1d3b
> c2b4c6fa92cd99c5c301635%7C0%7C0%7C636855892359986096&amp;sdat
> a=7yqUJVZrNl5lxUwn7g0CzgF9yg764AIeiVG7wIk%2Fgt0%3D&amp;reserved=
> 0
> FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps
> up According to speedtest.net: 11.9Mbps down 500kbps up