lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Mar 2019 12:28:31 +0000 From: Peng Fan <peng.fan@....com> To: Aisheng Dong <aisheng.dong@....com>, "shawnguo@...nel.org" <shawnguo@...nel.org>, "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>, "kernel@...gutronix.de" <kernel@...gutronix.de>, "festevam@...il.com" <festevam@...il.com>, dl-linux-imx <linux-imx@....com>, Anson Huang <anson.huang@....com>, "arnd@...db.de" <arnd@...db.de>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> CC: "van.freenix@...il.com" <van.freenix@...il.com> Subject: RE: [PATCH 2/2] ARM: imx: mach-imx7ulp: warn when imx_soc_device_init fail > -----Original Message----- > From: Aisheng Dong > Sent: 2019年3月15日 21:40 > To: Peng Fan <peng.fan@....com>; shawnguo@...nel.org; > s.hauer@...gutronix.de; kernel@...gutronix.de; festevam@...il.com; > dl-linux-imx <linux-imx@....com>; Anson Huang <anson.huang@....com>; > arnd@...db.de; linux-arm-kernel@...ts.infradead.org; > linux-kernel@...r.kernel.org > Cc: van.freenix@...il.com > Subject: RE: [PATCH 2/2] ARM: imx: mach-imx7ulp: warn when > imx_soc_device_init fail > > [...] > > > > > Follow other i.MX6/7 machince code to check return value of > > > > imx_soc_device_init and warn when fail. > > > > > > > > Also drop of_platform_default_populate, because > > > > "arch_initcall_sync(of_platform_default_populate_init);" could be > > > > used to populate the device tree. > > > > > > > > > > This could be in separate patch. > > > > I'll do it in v2 after we agree the change in the first patch. > > > > I think imx7ulp does not have the issue in patch 1. Missed to reply you. So do you agree to split this patch into two patches ? or leave the code as it is? The first is follow other i.mx6/7 to check return value of imx_soc_device_init. The second is drop the call to of_platform_default_populate. Thanks, Peng > > Regards > Dong Aisheng > > > > > > > > Signed-off-by: Peng Fan <peng.fan@....com> > > > > --- > > > > arch/arm/mach-imx/mach-imx7ulp.c | 7 ++++++- > > > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/arch/arm/mach-imx/mach-imx7ulp.c > > > > b/arch/arm/mach-imx/mach-imx7ulp.c > > > > index 11ac71aaf965..6d823f05d9aa 100644 > > > > --- a/arch/arm/mach-imx/mach-imx7ulp.c > > > > +++ b/arch/arm/mach-imx/mach-imx7ulp.c > > > > @@ -53,11 +53,16 @@ static void __init imx7ulp_set_revision(void) > > > > > > > > static void __init imx7ulp_init_machine(void) { > > > > + struct device *soc_dev; > > > > + > > > > + soc_dev = imx_soc_device_init(); > > > > + if (soc_dev == NULL) > > > > + pr_warn("failed to initialize soc device\n"); > > > > + > > > > > > Should this be under set revision? > > > > Just follow other i.MX6/7 platforms practice, I could move this under > > set revision in v2 if you prefer. > > > > Thanks, > > Peng. > > > > > > > > Regards > > > Dong Aisheng > > > > > > > imx7ulp_pm_init(); > > > > > > > > mxc_set_cpu_type(MXC_CPU_IMX7ULP); > > > > imx7ulp_set_revision(); > > > > - of_platform_default_populate(NULL, NULL, imx_soc_device_init()); > > > > } > > > > > > > > static const char *const imx7ulp_dt_compat[] __initconst = { > > > > -- > > > > 2.16.4
Powered by blists - more mailing lists