linux-kernel - Re: [PATCH] sched: Do not re-read h_load_next during hierarchical load calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cea29ed4-5ad0-7799-f421-9bd2a4a3fba3@arm.com>
Date:   Tue, 19 Mar 2019 12:36:04 +0000
From:   Valentin Schneider <valentin.schneider@....com>
To:     Mel Gorman <mgorman@...hsingularity.net>
Cc:     Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched: Do not re-read h_load_next during hierarchical
 load calculation

On 19/03/2019 12:30, Mel Gorman wrote:
[...]
>>
>> Does that also want a
>>
>> Fixes: 685207963be9 ("sched: Move h_load calculation to task_h_load()")
>> Cc: stable@...r.kernel.org
>>
>> ?
>>
>> Other than that, the change looks sane to me.
>>
>> Reviewed-by: Valentin Schneider <valentin.schneider@....com>
>>
> 
> Thanks. I'll add the Fixes because it does look like the old code would
> have been ok. Thanks for the review!
> 

Well it's not worth much because I completely skipped that we *didn't*
already have a WRITE_ONCE(), which you do need as Peter mentioned. But I
do think stable will be happy to get this one :)