linux-kernel - Re: [PATCH 1/6] regulator: da9063: remove platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190319124909.7dj6ns5kkgdj4lop@verge.net.au>
Date:   Tue, 19 Mar 2019 13:49:10 +0100
From:   Simon Horman <horms@...ge.net.au>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc:     linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        Lee Jones <lee.jones@...aro.org>,
        Mark Brown <broonie@...nel.org>,
        Support Opensource <support.opensource@...semi.com>,
        Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [PATCH 1/6] regulator: da9063: remove platform_data support

On Mon, Mar 18, 2019 at 04:47:53PM +0100, Wolfram Sang wrote:
> There are no in-kernel users anymore, so remove this outdated interface.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>

Reviewed-by: Simon Horman <horms+renesas@...ge.net.au>

> ---
>  drivers/regulator/da9063-regulator.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-regulator.c
> index 2b0c7a85306a..73c85039d0cf 100644
> --- a/drivers/regulator/da9063-regulator.c
> +++ b/drivers/regulator/da9063-regulator.c
> @@ -730,7 +730,6 @@ static struct da9063_regulators_pdata *da9063_parse_regulators_dt(
>  static int da9063_regulator_probe(struct platform_device *pdev)
>  {
>  	struct da9063 *da9063 = dev_get_drvdata(pdev->dev.parent);
> -	struct da9063_pdata *da9063_pdata = dev_get_platdata(da9063->dev);
>  	struct of_regulator_match *da9063_reg_matches = NULL;
>  	struct da9063_regulators_pdata *regl_pdata;
>  	const struct da9063_dev_model *model;
> @@ -740,11 +739,7 @@ static int da9063_regulator_probe(struct platform_device *pdev)
>  	bool bcores_merged, bmem_bio_merged;
>  	int id, irq, n, n_regulators, ret, val;
>  
> -	regl_pdata = da9063_pdata ? da9063_pdata->regulators_pdata : NULL;
> -
> -	if (!regl_pdata)
> -		regl_pdata = da9063_parse_regulators_dt(pdev,
> -							&da9063_reg_matches);
> +	regl_pdata = da9063_parse_regulators_dt(pdev, &da9063_reg_matches);
>  
>  	if (IS_ERR(regl_pdata) || regl_pdata->n_regulators == 0) {
>  		dev_err(&pdev->dev,
> -- 
> 2.11.0
>