linux-kernel - Re: [PATCH 1/2] w1: ds2408: add a missing reset when retrying in output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <3E9B4A8B-6409-4102-A3A2-40853AD04DB1@gmail.com>
Date:   Tue, 19 Mar 2019 10:25:50 -0400
From:   Jean-Francois Dagenais <jeff.dagenais@...il.com>
To:     Mariusz Bialonczyk <manio@...boo.net>
Cc:     open list <linux-kernel@...r.kernel.org>,
        Evgeniy Polyakov <zbr@...emap.net>,
        Greg Kroah-Hartman <greg@...ah.com>
Subject: Re: [PATCH 1/2] w1: ds2408: add a missing reset when retrying in
 output_write()



> On Mar 19, 2019, at 10:21, Jean-Francois Dagenais <jeff.dagenais@...il.com> wrote:
> 
> I can do a proper patch submission if you guys provide positive response on this
> early RFC. Or better yet, you can take it and own it yourself as your v2
> Mariusz. ;)

Just FYI, here's what the retry loop looks like after this suggested patch:

	do {
		w1_buf[0] = W1_F29_FUNC_CHANN_ACCESS_WRITE;
		w1_buf[1] = *buf;
		w1_buf[2] = ~(*buf);
		w1_write_block(sl->master, w1_buf, 3);

		readBack = w1_read_8(sl->master);

		if (readBack == W1_F29_SUCCESS_CONFIRM_BYTE &&
		    optional_read_back_valid(sl, *buf)) {
			bytes_written = 1;
			goto out;
		}

		if (w1_reset_resume_command(sl->master))
			goto out; /* unrecoverable error */
		/* try again, the slave is ready for a command */
	} while (--retries);


Much better on the eyes.