linux-kernel - Re: [PATCH -next] drivers: base: swnode: Make two functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jSPD-jypMCQFOeLEE3nKpyaV=XEC6Gq=0vZ7DYcDM_1w@mail.gmail.com>
Date:   Tue, 19 Mar 2019 16:40:14 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Yue Haibing <yuehaibing@...wei.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] drivers: base: swnode: Make two functions static

On Tue, Mar 19, 2019 at 4:20 PM Yue Haibing <yuehaibing@...wei.com> wrote:
>
> From: YueHaibing <yuehaibing@...wei.com>
>
> Fix sparse warning:
>
> drivers/base/swnode.c:475:22: warning: symbol 'software_node_get_parent' was not declared. Should it be static?
> drivers/base/swnode.c:484:22: warning: symbol 'software_node_get_next_child' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

I'll queue this up as device properties material for -rc2, thanks!

> ---
>  drivers/base/swnode.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c
> index 1fad929..7fc5a18 100644
> --- a/drivers/base/swnode.c
> +++ b/drivers/base/swnode.c
> @@ -472,7 +472,7 @@ static int software_node_read_string_array(const struct fwnode_handle *fwnode,
>                                                 val, nval);
>  }
>
> -struct fwnode_handle *
> +static struct fwnode_handle *
>  software_node_get_parent(const struct fwnode_handle *fwnode)
>  {
>         struct software_node *swnode = to_software_node(fwnode);
> @@ -481,7 +481,7 @@ software_node_get_parent(const struct fwnode_handle *fwnode)
>                         NULL;
>  }
>
> -struct fwnode_handle *
> +static struct fwnode_handle *
>  software_node_get_next_child(const struct fwnode_handle *fwnode,
>                              struct fwnode_handle *child)
>  {
> --