linux-kernel - Re: [PATCH] clk: meson-gxbb: round the vdec dividers to closest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 19 Mar 2019 17:32:46 +0100
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Maxime Jourdan <mjourdan@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>
Cc:     linux-clk@...r.kernel.org, linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: meson-gxbb: round the vdec dividers to closest

On 19/03/2019 11:25, Maxime Jourdan wrote:
> We want the video decoder clocks to always round to closest. While the
> muxes are already using CLK_MUX_ROUND_CLOSEST, the corresponding
> CLK_DIVIDER_ROUND_CLOSEST was forgotten for the dividers.
> 
> Fix this by adding the flag to the two vdec dividers.
> 
> Fixes: a565242eb9fc ("clk: meson: gxbb: add the video decoder clocks")
> Signed-off-by: Maxime Jourdan <mjourdan@...libre.com>
> ---
>  drivers/clk/meson/gxbb.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c
> index 04df2e208ed6..29ffb4fde714 100644
> --- a/drivers/clk/meson/gxbb.c
> +++ b/drivers/clk/meson/gxbb.c
> @@ -2216,6 +2216,7 @@ static struct clk_regmap gxbb_vdec_1_div = {
>  		.offset = HHI_VDEC_CLK_CNTL,
>  		.shift = 0,
>  		.width = 7,
> +		.flags = CLK_DIVIDER_ROUND_CLOSEST,
>  	},
>  	.hw.init = &(struct clk_init_data){
>  		.name = "vdec_1_div",
> @@ -2261,6 +2262,7 @@ static struct clk_regmap gxbb_vdec_hevc_div = {
>  		.offset = HHI_VDEC2_CLK_CNTL,
>  		.shift = 16,
>  		.width = 7,
> +		.flags = CLK_DIVIDER_ROUND_CLOSEST,
>  	},
>  	.hw.init = &(struct clk_init_data){
>  		.name = "vdec_hevc_div",
> 

Acked-by: Neil Armstrong <narmstrong@...libre.com>

Will apply to fixes/drivers for 5.1