linux-kernel - Re: [PATCH v2 07/19] locking/lockdep: Update obsolete struct field description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1553013349.65329.0.camel@acm.org>
Date:   Tue, 19 Mar 2019 09:35:49 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Yuyang Du <duyuyang@...il.com>, peterz@...radead.org,
        will.deacon@....com, mingo@...nel.org
Cc:     ming.lei@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 07/19] locking/lockdep: Update obsolete struct field
 description

On Mon, 2019-03-18 at 16:57 +0800, Yuyang Du wrote:
>  struct lock_chain {
> -       /* see BUILD_BUG_ON()s in lookup_chain_cache() */
> +       /*
> +        * irq_context: the same as irq_context in held_lock below
> +        * depth:       the number of held locks in this chain
> +        * base:        the index in chain_hlocks for this chain
> +        */
>         unsigned int                    irq_context :  2,
>                                         depth       :  6,
>                                         base        : 24;

Have you considered to use the kernel-doc style for documenting these
structure members?

Thanks,

Bart.