linux-kernel - [PATCH] infiniband:qplib_fp:move spin_lock_bh to spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 Mar 2019 00:36:37 +0800
From:   Jeff Xie <chongguiguzi@...il.com>
To:     selvin.xavier@...adcom.com, devesh.sharma@...adcom.com
Cc:     somnath.kotur@...adcom.com, chongguiguzi@...il.com,
        sriharsha.basavapatna@...adcom.com, dledford@...hat.com,
        jgg@...pe.ca, nux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] infiniband:qplib_fp:move spin_lock_bh to spin_lock in tasklet

It is unnecessary to call spin_lock_bh in a tasklet.

Signed-off-by: Jeff Xie <chongguiguzi@...il.com>
---
 drivers/infiniband/hw/bnxt_re/qplib_fp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/bnxt_re/qplib_fp.c b/drivers/infiniband/hw/bnxt_re/qplib_fp.c
index 71c34d5..e2541c9 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_fp.c
+++ b/drivers/infiniband/hw/bnxt_re/qplib_fp.c
@@ -273,14 +273,14 @@ static void bnxt_qplib_service_nq(unsigned long data)
 						     << 32;
 			cq = (struct bnxt_qplib_cq *)(unsigned long)q_handle;
 			bnxt_qplib_arm_cq_enable(cq);
-			spin_lock_bh(&cq->compl_lock);
+			spin_lock(&cq->compl_lock);
 			atomic_set(&cq->arm_state, 0);
 			if (!nq->cqn_handler(nq, (cq)))
 				num_cqne_processed++;
 			else
 				dev_warn(&nq->pdev->dev,
 					 "cqn - type 0x%x not handled\n", type);
-			spin_unlock_bh(&cq->compl_lock);
+			spin_unlock(&cq->compl_lock);
 			break;
 		}
 		case NQ_BASE_TYPE_SRQ_EVENT:
-- 
2.7.4