[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190319164432.GD6058@hirez.programming.kicks-ass.net>
Date: Tue, 19 Mar 2019 17:44:32 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: Bart Van Assche <bvanassche@....org>
Cc: Yuyang Du <duyuyang@...il.com>, will.deacon@....com,
mingo@...nel.org, ming.lei@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 07/19] locking/lockdep: Update obsolete struct field
description
On Tue, Mar 19, 2019 at 09:35:49AM -0700, Bart Van Assche wrote:
> On Mon, 2019-03-18 at 16:57 +0800, Yuyang Du wrote:
> > struct lock_chain {
> > - /* see BUILD_BUG_ON()s in lookup_chain_cache() */
That's add_chain_cache() now, please do keep the reference.
> > + /*
> > + * irq_context: the same as irq_context in held_lock below
> > + * depth: the number of held locks in this chain
> > + * base: the index in chain_hlocks for this chain
> > + */
> > unsigned int irq_context : 2,
> > depth : 6,
> > base : 24;
>
> Have you considered to use the kernel-doc style for documenting these
> structure members?
>
> Thanks,
>
> Bart.
Powered by blists - more mailing lists