linux-kernel - Re: [PATCH -next] crypto: ccp - Make ccp_register_rsa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <595b4fe4-acf1-97fc-c49d-5d3be2d83284@amd.com>
Date:   Tue, 19 Mar 2019 18:39:03 +0000
From:   Gary R Hook <ghook@....com>
To:     Yue Haibing <yuehaibing@...wei.com>,
        "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
        "Lendacky, Thomas" <Thomas.Lendacky@....com>,
        "Hook, Gary" <Gary.Hook@....com>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>
Subject: Re: [PATCH -next] crypto: ccp - Make ccp_register_rsa_alg static

On 3/19/19 8:50 AM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@...wei.com>
> 
> Fix sparse warning:
> 
> drivers/crypto/ccp/ccp-crypto-rsa.c:251:5:
>   warning: symbol 'ccp_register_rsa_alg' was not declared. Should it be static?
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Acked-by: Gary R Hook <gary.hook@....com.

> ---
>   drivers/crypto/ccp/ccp-crypto-rsa.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/ccp/ccp-crypto-rsa.c b/drivers/crypto/ccp/ccp-crypto-rsa.c
> index 05850df..0b8aab00 100644
> --- a/drivers/crypto/ccp/ccp-crypto-rsa.c
> +++ b/drivers/crypto/ccp/ccp-crypto-rsa.c
> @@ -248,7 +248,8 @@ static struct ccp_rsa_def rsa_algs[] = {
>   	}
>   };
>   
> -int ccp_register_rsa_alg(struct list_head *head, const struct ccp_rsa_def *def)
> +static int ccp_register_rsa_alg(struct list_head *head,
> +			        const struct ccp_rsa_def *def)
>   {
>   	struct ccp_crypto_akcipher_alg *ccp_alg;
>   	struct akcipher_alg *alg;
>