linux-kernel - Re: linux-next: build warning after merge of the leds tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 19 Mar 2019 20:53:40 +0100
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Kangjie Lu <kjlu@....edu>
Subject: Re: linux-next: build warning after merge of the leds tree

Hi Stephen,

Thank you for the report.

On 3/19/19 3:58 AM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the leds tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/leds/leds-pca9532.c: In function 'pca9532_probe':
> drivers/leds/leds-pca9532.c:536:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>     devid = (int)of_id->data;
>             ^

Applied the fixup to the original commit, which missed to carry
the cast properly from the previous state of code.

-               devid = (int)of_id->data;
+               devid = (int)(uintptr_t) of_id->data;


> Introduced by commit
> 
>    6b788fae618c ("leds: fix a potential NULL pointer dereference")
> 

-- 
Best regards,
Jacek Anaszewski