[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAGb2v64HJX+2rC14OEPgBSc61h-8KCAthdyY05xTuquKYTfsRA@mail.gmail.com>
Date: Tue, 19 Mar 2019 11:17:31 +0800
From: Chen-Yu Tsai <wens@...nel.org>
To: Samuel Holland <samuel@...lland.org>
Cc: Chen-Yu Tsai <wens@...nel.org>,
Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
Maxime Ripard <maxime.ripard@...tlin.com>,
linux-sunxi <linux-sunxi@...glegroups.com>,
linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
devicetree <devicetree@...r.kernel.org>,
linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [linux-sunxi] [PATCH 6/6] ARM: dts: sunxi: h3/h5: Add device node
for SID
On Tue, Mar 19, 2019 at 9:55 AM Samuel Holland <samuel@...lland.org> wrote:
>
> On 03/18/19 02:33, Chen-Yu Tsai wrote:
> > From: Chen-Yu Tsai <wens@...e.org>
> >
> > The device tree binding already lists compatible strings for these two
> > SoCs. Add a device node for them.
> >
> > Signed-off-by: Chen-Yu Tsai <wens@...e.org>
> > ---
> > arch/arm/boot/dts/sun8i-h3.dtsi | 4 ++++
> > arch/arm/boot/dts/sunxi-h3-h5.dtsi | 5 +++++
> > arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 4 ++++
> > 3 files changed, 13 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
> > index 959d265e7254..e37c30e811d3 100644
> > --- a/arch/arm/boot/dts/sun8i-h3.dtsi
> > +++ b/arch/arm/boot/dts/sun8i-h3.dtsi
> > @@ -231,3 +231,7 @@
> > &rtc {
> > compatible = "allwinner,sun8i-h3-rtc";
> > };
> > +
> > +&sid {
> > + compatible = "allwinner,sun8i-h3-sid";
> > +};
> > diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> > index d74a6cbbfdf4..e2100b673a51 100644
> > --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> > +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> > @@ -227,6 +227,11 @@
> > #size-cells = <0>;
> > };
> >
> > + sid: eeprom@...4000 {
> > + /* compatible and clocks are in per SoC .dtsi file */
>
> There are no clocks for this node, just a compatible string.
Right. I'll fix this when applying.
ChenYu
Powered by blists - more mailing lists