linux-kernel - Re: [PATCH] sh: mm: make use of new memblocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190319203912.GA17966@rapoport-lnx>
Date:   Tue, 19 Mar 2019 22:39:12 +0200
From:   Mike Rapoport <rppt@...ux.ibm.com>
To:     Logan Gunthorpe <logang@...tatee.com>
Cc:     linux-sh@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Michal Hocko <mhocko@...e.com>, Christoph Hellwig <hch@....de>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>
Subject: Re: [PATCH] sh: mm: make use of new memblocks_present() helper

On Tue, Mar 19, 2019 at 12:09:30PM -0600, Logan Gunthorpe wrote:
> Cleanup the open coded for_each_memblock() loop that is equivalent
> to the new memblocks_present() helper.
> 
> Signed-off-by: Logan Gunthorpe <logang@...tatee.com>
> Reviewed-by: Christoph Hellwig <hch@....de>
> Cc: Yoshinori Sato <ysato@...rs.sourceforge.jp>
> Cc: Rich Felker <dalias@...c.org>

Reviewed-by: Mike Rapoport <rppt@...ux.ibm.com>

> ---
>  arch/sh/mm/init.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> This is just a resend
> 
> diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c
> index a8e5c0e00fca..dc0ff41d602d 100644
> --- a/arch/sh/mm/init.c
> +++ b/arch/sh/mm/init.c
> @@ -234,12 +234,7 @@ static void __init do_init_bootmem(void)
> 
>  	plat_mem_setup();
> 
> -	for_each_memblock(memory, reg) {
> -		int nid = memblock_get_region_node(reg);
> -
> -		memory_present(nid, memblock_region_memory_base_pfn(reg),
> -			memblock_region_memory_end_pfn(reg));
> -	}
> +	memblocks_present();
>  	sparse_init();
>  }
> 
> --
> 2.19.0
> 

-- 
Sincerely yours,
Mike.