linux-kernel - Re: [PATCH] ARM: mm: make use of new memblocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a9b528f1-0c4b-3894-18e1-a4999c18f4a4@deltatee.com>
Date:   Tue, 19 Mar 2019 14:50:25 -0600
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Mike Rapoport <rppt@...ux.ibm.com>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Rob Herring <robh@...nel.org>,
        Russell King <linux@...linux.org.uk>,
        Kees Cook <keescook@...omium.org>,
        Philip Derrin <philip@....systems>,
        "Steven Rostedt (VMware)" <rostedt@...dmis.org>,
        Nicolas Pitre <nicolas.pitre@...aro.org>
Subject: Re: [PATCH] ARM: mm: make use of new memblocks_present() helper



On 2019-03-19 2:42 p.m., Mike Rapoport wrote:
> On Tue, Mar 19, 2019 at 12:13:57PM -0600, Logan Gunthorpe wrote:
>> Cleanup the arm_memory_present() function seeing it's very
>> similar to other arches.
>>
>> The new memblocks_present() helper checks for node ids which the
>> arm version did not. However, this is equivalent seeing
>> HAVE_MEMBLOCK_NODE_MAP should be false in this arch and therefore
>> memblock_get_region_node() should return 0.
>>
>> Signed-off-by: Logan Gunthorpe <logang@...tatee.com>
>> Cc: Russell King <linux@...linux.org.uk>
>> Cc: Kees Cook <keescook@...omium.org>
>> Cc: Philip Derrin <philip@....systems>
>> Cc: "Steven Rostedt (VMware)" <rostedt@...dmis.org>
>> Cc: Nicolas Pitre <nicolas.pitre@...aro.org>
> 
> Reviewed-by: Mike Rapoport <rppt@...ux.ibm.com>
> 
> Strangely, I've got a feeling I've already reviewed such patch from a
> different person...

You're probably referring to [1] which was for arm64 and was redundant
as my patch for that architecture was already picked up by Catalin.

I was the person who originally introduced memblocks_present() and I'm
still hoping to get the cleanup patches for the arm and sh arches to be
picked up.

Thanks,

Logan

[1]
https://lore.kernel.org/lkml/20190210093738.30923-1-peng.fan@nxp.com/T/#u