linux-kernel - Re: [PATCH -next] KVM: arm: vgic: Make two functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <de8edaed-a37b-f143-75d8-9db9c45c5543@codeaurora.org>
Date:   Thu, 21 Mar 2019 00:38:24 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Yue Haibing <yuehaibing@...wei.com>, christoffer.dall@....com,
        marc.zyngier@....com, james.morse@....com, julien.thierry@....com,
        suzuki.poulose@....com, andre.przywara@....com
Cc:     linux-kernel@...r.kernel.org, kvmarm@...ts.cs.columbia.edu,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH -next] KVM: arm: vgic: Make two functions static


On 3/20/2019 7:48 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@...wei.com>
>
> Fix sparse warnings:
>
> arch/arm64/kvm/../../../virt/kvm/arm/vgic/vgic-its.c:1732:5: warning:
>   symbol 'vgic_its_has_attr_regs' was not declared. Should it be static?
> arch/arm64/kvm/../../../virt/kvm/arm/vgic/vgic-its.c:1753:5: warning:
>   symbol 'vgic_its_attr_regs_access' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>   virt/kvm/arm/vgic/vgic-its.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c
> index ab3f477..a97db69 100644
> --- a/virt/kvm/arm/vgic/vgic-its.c
> +++ b/virt/kvm/arm/vgic/vgic-its.c
> @@ -1729,8 +1729,8 @@ static void vgic_its_destroy(struct kvm_device *kvm_dev)
>   	kfree(its);
>   }
>   
> -int vgic_its_has_attr_regs(struct kvm_device *dev,
> -			   struct kvm_device_attr *attr)
> +static int vgic_its_has_attr_regs(struct kvm_device *dev,
> +				  struct kvm_device_attr *attr)
>   {
>   	const struct vgic_register_region *region;
>   	gpa_t offset = attr->attr;
> @@ -1750,9 +1750,9 @@ int vgic_its_has_attr_regs(struct kvm_device *dev,
>   	return 0;
>   }
>   
> -int vgic_its_attr_regs_access(struct kvm_device *dev,
> -			      struct kvm_device_attr *attr,
> -			      u64 *reg, bool is_write)
> +static int vgic_its_attr_regs_access(struct kvm_device *dev,
> +				     struct kvm_device_attr *attr,
> +				     u64 *reg, bool is_write)
>   {
>   	const struct vgic_register_region *region;
>   	struct vgic_its *its;


Acked-by: Mukesh Ojha <mojha@...eaurora.org>

Cheers,
Mukesh