linux-kernel - Re: [PATCH -next] watchdog: sb_wdog: Make sbwdog_set and sbwdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45a85dca-93e8-80eb-3392-028a3dca4b3d@codeaurora.org>
Date:   Thu, 21 Mar 2019 00:57:00 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Yue Haibing <yuehaibing@...wei.com>, wim@...ux-watchdog.org,
        linux@...ck-us.net
Cc:     linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org
Subject: Re: [PATCH -next] watchdog: sb_wdog: Make sbwdog_set and sbwdog_pet
 static


On 3/20/2019 7:12 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@...wei.com>
>
> Fix sparse warning:
>
> drivers/watchdog/sb_wdog.c:70:6: warning: symbol 'sbwdog_set' was not declared. Should it be static?
> drivers/watchdog/sb_wdog.c:84:6: warning: symbol 'sbwdog_pet' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>   drivers/watchdog/sb_wdog.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/sb_wdog.c b/drivers/watchdog/sb_wdog.c
> index 3abae50..8264fced 100644
> --- a/drivers/watchdog/sb_wdog.c
> +++ b/drivers/watchdog/sb_wdog.c
> @@ -67,7 +67,7 @@ static DEFINE_SPINLOCK(sbwd_lock);
>    *
>    * wdog is the iomem address of the cfg register
>    */
> -void sbwdog_set(char __iomem *wdog, unsigned long t)
> +static void sbwdog_set(char __iomem *wdog, unsigned long t)
>   {
>   	spin_lock(&sbwd_lock);
>   	__raw_writeb(0, wdog);
> @@ -81,7 +81,7 @@ void sbwdog_set(char __iomem *wdog, unsigned long t)
>    *
>    * wdog is the iomem address of the cfg register
>    */
> -void sbwdog_pet(char __iomem *wdog)
> +static void sbwdog_pet(char __iomem *wdog)
>   {
>   	spin_lock(&sbwd_lock);
>   	__raw_writeb(__raw_readb(wdog) | 1, wdog);


Acked-by: Mukesh Ojha <mojha@...eaurora.org>


Thanks.

Mukesh