linux-kernel - Re: [PATCH -next] irqchip/brcmstb-l2: Make two init functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Mar 2019 01:07:01 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Yue Haibing <yuehaibing@...wei.com>, cernekee@...il.com,
        f.fainelli@...il.com, tglx@...utronix.de, jason@...edaemon.net,
        marc.zyngier@....com, computersforpeace@...il.com,
        gregory.0xf0@...il.com, bcm-kernel-feedback-list@...adcom.com
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mips@...r.kernel.org
Subject: Re: [PATCH -next] irqchip/brcmstb-l2: Make two init functions static


On 3/20/2019 7:52 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@...wei.com>
>
> Fix sparse warnings:
>
> drivers/irqchip/irq-brcmstb-l2.c:278:12: warning:
>   symbol 'brcmstb_l2_edge_intc_of_init' was not declared. Should it be static?
> drivers/irqchip/irq-brcmstb-l2.c:285:12: warning:
>   symbol 'brcmstb_l2_lvl_intc_of_init' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>   drivers/irqchip/irq-brcmstb-l2.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-brcmstb-l2.c b/drivers/irqchip/irq-brcmstb-l2.c
> index 83364fe..5e4ca13 100644
> --- a/drivers/irqchip/irq-brcmstb-l2.c
> +++ b/drivers/irqchip/irq-brcmstb-l2.c
> @@ -275,14 +275,14 @@ static int __init brcmstb_l2_intc_of_init(struct device_node *np,
>   	return ret;
>   }
>   
> -int __init brcmstb_l2_edge_intc_of_init(struct device_node *np,
> +static int __init brcmstb_l2_edge_intc_of_init(struct device_node *np,
>   	struct device_node *parent)
>   {
>   	return brcmstb_l2_intc_of_init(np, parent, &l2_edge_intc_init);
>   }
>   IRQCHIP_DECLARE(brcmstb_l2_intc, "brcm,l2-intc", brcmstb_l2_edge_intc_of_init);
>   
> -int __init brcmstb_l2_lvl_intc_of_init(struct device_node *np,
> +static int __init brcmstb_l2_lvl_intc_of_init(struct device_node *np,
>   	struct device_node *parent)
>   {
>   	return brcmstb_l2_intc_of_init(np, parent, &l2_lvl_intc_init);


Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>


Thanks,
Mukesh