linux-kernel - Re: [PATCH -next] proc/kcore: Make kcore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6af0854e-b2c4-e5ce-ea2c-082d35f5e96e@codeaurora.org>
Date:   Thu, 21 Mar 2019 01:25:30 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Yue Haibing <yuehaibing@...wei.com>, adobriyan@...il.com,
        akpm@...ux-foundation.org, osandov@...com, james.morse@....com,
        sfr@...b.auug.org.au
Cc:     linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH -next] proc/kcore: Make kcore_modules static


On 3/20/2019 7:24 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@...wei.com>
>
> Fix sparse warning:
>
> fs/proc/kcore.c:591:19: warning:
>   symbol 'kcore_modules' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>   fs/proc/kcore.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c
> index bbcc185..378f453 100644
> --- a/fs/proc/kcore.c
> +++ b/fs/proc/kcore.c
> @@ -588,7 +588,7 @@ static void __init proc_kcore_text_init(void)
>   /*
>    * MODULES_VADDR has no intersection with VMALLOC_ADDR.
>    */
> -struct kcore_list kcore_modules;
> +static struct kcore_list kcore_modules;
>   static void __init add_modules_range(void)
>   {
>   	if (MODULES_VADDR != VMALLOC_START && MODULES_END != VMALLOC_END) {


Acked-by: Mukesh Ojha <mojha@...eaurora.org>