linux-kernel - Re: [PATCH -next] pinctrl: fsl: Make pinctrl_ipc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38d8265b-52b9-f7fd-d665-46b66848118a@codeaurora.org>
Date:   Thu, 21 Mar 2019 01:28:28 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     Yue Haibing <yuehaibing@...wei.com>, aisheng.dong@....com,
        festevam@...il.com, shawnguo@...nel.org, stefan@...er.ch,
        kernel@...gutronix.de, linus.walleij@...aro.org
Cc:     linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH -next] pinctrl: fsl: Make pinctrl_ipc_handle static


On 3/20/2019 7:44 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@...wei.com>
>
> Fix sparse warning:
>
> drivers/pinctrl/freescale/pinctrl-scu.c:38:19: warning:
>   symbol 'pinctrl_ipc_handle' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>   drivers/pinctrl/freescale/pinctrl-scu.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/freescale/pinctrl-scu.c b/drivers/pinctrl/freescale/pinctrl-scu.c
> index 83e69c0..73bf1d9 100644
> --- a/drivers/pinctrl/freescale/pinctrl-scu.c
> +++ b/drivers/pinctrl/freescale/pinctrl-scu.c
> @@ -35,7 +35,7 @@ struct imx_sc_msg_resp_pad_get {
>   	u32 val;
>   } __packed;
>   
> -struct imx_sc_ipc *pinctrl_ipc_handle;
> +static struct imx_sc_ipc *pinctrl_ipc_handle;
>   
>   int imx_pinctrl_sc_ipc_init(struct platform_device *pdev)
>   {


Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>