linux-kernel - Re: [PATCH v3] ARM: tegra: enforce PM requirement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <226b42a9-766f-2124-6af9-891694ad1195@nvidia.com>
Date:   Wed, 20 Mar 2019 09:48:06 +0530
From:   Sameer Pujar <spujar@...dia.com>
To:     Dmitry Osipenko <digetx@...il.com>, <linux@...linux.org.uk>,
        <jhogan@...nel.org>, <jonathanh@...dia.com>, <treding@...dia.com>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-tegra@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] ARM: tegra: enforce PM requirement


On 2/27/2019 7:01 PM, Dmitry Osipenko wrote:
> 27.02.2019 11:20, Sameer Pujar пишет:
>> Currently runtime PM is enabled for Tegra HDA driver. One of the concern
>> raised was about handling !PM case in HDA driver. In this case, there is
>> a need to manage clocks and power explicitly in the driver and reviewers
>> were not really convinced about this. The consensus at the end was to
>> enforce PM requirement to keep things simple, rather driver mentioning a
>> dependency on PM. This is how it is done for ARM 64-bit Tegra platforms
>> and the same can be done for 32-bit Tegra platforms too.
>>
>> Finally the objective is to remove dependency on PM availability for all
>> Tegra drivers. The detailed discussion can be found in following patch,
>> https://patchwork.ozlabs.org/patch/1031007/
>>
>> Signed-off-by: Sameer Pujar <spujar@...dia.com>
>> Reviewed-by: Thierry Reding <treding@...dia.com>
>> Reviewed-by: Jonathan Hunter <jonathanh@...dia.com>
>> ---
> The commit message is okay to me this time, thanks! I'm still not super-happy to lose the !PM option because of its value in regards to the PM debugging, but again we can just do something better in that regards later on if will be really needed.
>
> Reviewed-by: Dmitry Osipenko <digetx@...il.com>
Do we have any further concerns over the patch? Request maintainers for 
merge otherwise.