linux-kernel - Re: [PATCH v2] usb: introduce usb_ep_type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 Mar 2019 08:55:11 +0200
From:   Felipe Balbi <balbi@...nel.org>
To:     Chunfeng Yun <chunfeng.yun@...iatek.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Mathias Nyman <mathias.nyman@...el.com>,
        Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Arnd Bergmann <arnd@...db.de>, Roger Quadros <rogerq@...com>,
        Alan Stern <stern@...land.harvard.edu>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Dmitry Torokhov <dtor@...omium.org>,
        Johan Hovold <johan@...nel.org>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Colin Ian King <colin.king@...onical.com>,
        Matteo Croce <mcroce@...hat.com>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-aspeed@...ts.ozlabs.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v2] usb: introduce usb_ep_type_string() function

Chunfeng Yun <chunfeng.yun@...iatek.com> writes:

> Hi Greg,
>
> On Tue, 2019-03-19 at 10:23 +0100, Greg Kroah-Hartman wrote:
>> On Tue, Mar 19, 2019 at 03:54:19PM +0800, Chunfeng Yun wrote:
>> > 
>> > Hi Felipe & Mathias,
>> > 
>> > Could you please comment this patch, if there is some-effect on dwc3 and
>> > xhci, I'll remove its change.
> typo: some-effect/side-effect

well, we don't really know if there are tools parsing the output. The
side-effect _does_ exist (i.e. you change the string :-), what we don't
know is if this will cause problems to possibly existing tools.

Personally, I don't mind the patch, but if it breaks existing parsers,
that would be a little annoying.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)