linux-kernel - Re: [Intel-wired-lan] [PATCH net-next] igc: Make igc_write_rss_indir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 20 Mar 2019 15:52:11 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     "Neftin, Sasha" <sasha.neftin@...el.com>, <davem@...emloft.net>,
        <jeffrey.t.kirsher@...el.com>
CC:     <netdev@...r.kernel.org>, <intel-wired-lan@...ts.osuosl.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH net-next] igc: Make
 igc_write_rss_indir_tbl static


On 2019/3/20 15:07, Neftin, Sasha wrote:
> On 3/19/2019 16:55, Yue Haibing wrote:
>> From: YueHaibing <yuehaibing@...wei.com>
>>
>> Fix sparse warning:
>>
>> drivers/net/ethernet/intel/igc/igc_ethtool.c:646:6:
>>   warning: symbol 'igc_write_rss_indir_tbl' was not declared. Should it be static?
>>
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>> ---
>>   drivers/net/ethernet/intel/igc/igc_ethtool.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
>> index eff37a6..5442394 100644
>> --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
>> +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
>> @@ -643,7 +643,7 @@ static int igc_set_coalesce(struct net_device *netdev,
>>       return 0;
>>   }
>>   -void igc_write_rss_indir_tbl(struct igc_adapter *adapter)
>> +static void igc_write_rss_indir_tbl(struct igc_adapter *adapter)
>>   {
>>       struct igc_hw *hw = &adapter->hw;
>>       u32 reg = IGC_RETA(0);
>>
> The 'igc_write_rss_indir_tbl' method is declared in igc.h and used in igc_main.c
> Please, refer to latest Jeff next-queue, there is latest patches used these methods.

Well, I did not refer to Jeff's tree. So this patch can be dropped.

Thanks!

> 
> .
>