linux-kernel - Re: [PATCH] infiniband:qplib_fp:move spin_lock_bh to spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 20 Mar 2019 08:49:12 +0800
From:   谢欢 <chongguiguzi@...il.com>
To:     Jason Gunthorpe <jgg@...pe.ca>
Cc:     selvin.xavier@...adcom.com, devesh.sharma@...adcom.com,
        somnath.kotur@...adcom.com, sriharsha.basavapatna@...adcom.com,
        dledford@...hat.com, nux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] infiniband:qplib_fp:move spin_lock_bh to spin_lock in tasklet

It was only called in the tasklet context.

root@...f:~/git/linux-next# git grep -in  bnxt_qplib_service_nq
drivers/infiniband/hw/bnxt_re/qplib_fp.c:236:static void
bnxt_qplib_service_nq(unsigned long data)
drivers/infiniband/hw/bnxt_re/qplib_fp.c:390:
tasklet_init(&nq->worker, bnxt_qplib_service_nq,


  thanks.

Jason Gunthorpe <jgg@...pe.ca> 于2019年3月20日周三 上午3:22写道：
>
> On Wed, Mar 20, 2019 at 12:36:37AM +0800, Jeff Xie wrote:
> > It is unnecessary to call spin_lock_bh in a tasklet.
> >
> > Signed-off-by: Jeff Xie <chongguiguzi@...il.com>
> > ---
> >  drivers/infiniband/hw/bnxt_re/qplib_fp.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
>
> I'm curious, how did you prove this was always in a tasklet?
>
> Jason



-- 
jeff