linux-kernel - Re: [PATCH] blk-mq: fix a hung issue when set device state to blocked and restore running

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190320092951.GA9051@ming.t460p>
Date:   Wed, 20 Mar 2019 17:29:53 +0800
From:   Ming Lei <ming.lei@...hat.com>
To:     "zhengbin (A)" <zhengbin13@...wei.com>
Cc:     axboe@...nel.dk, hch@....de, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, houtao1@...wei.com,
        yanaijie@...wei.com, jianchao.w.wang@...cle.com
Subject: Re: [PATCH] blk-mq: fix a hung issue when set device state to
 blocked and restore running

On Wed, Mar 20, 2019 at 04:52:40PM +0800, zhengbin (A) wrote:
> Thanks for your quick reply, I will study BLK_STS_DEV_RESOURCE in detail
> 
> > BLK_STS_DEV_RESOURCE means that the driver will rerun hw queue, so
> > maybe you need to investigate why it is returned from scsi driver first.
> because we set the device state to blocked,
> scsi_queue_rq-->prep_to_mq(return BLK_STS_RESOURCE)
> 	     -->out_put_budget  transfer BLK_STS_RESOURCE to BLK_STS_DEV_RESOURCE
> In this situtation, the request does not send to the driver.

Then the queue will be run when the scsi_device becomes un-blocked,
see scsi_internal_device_unblock_nowait().


Thanks,
Ming