linux-kernel - Re: [PATCH v12 00/13] arm64: untag user pointers passed to the kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190320112545.GB25040@arrakis.emea.arm.com>
Date:   Wed, 20 Mar 2019 11:25:46 +0000
From:   Catalin Marinas <catalin.marinas@....com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Andrey Konovalov <andreyknvl@...gle.com>,
        Will Deacon <will.deacon@....com>,
        Mark Rutland <mark.rutland@....com>,
        Robin Murphy <robin.murphy@....com>,
        Kees Cook <keescook@...omium.org>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Ingo Molnar <mingo@...nel.org>,
        "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
        Shuah Khan <shuah@...nel.org>,
        Vincenzo Frascino <vincenzo.frascino@....com>,
        Eric Dumazet <edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, linux-doc@...r.kernel.org,
        linux-mm@...ck.org, linux-arch@...r.kernel.org,
        netdev@...r.kernel.org, bpf@...r.kernel.org,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Kostya Serebryany <kcc@...gle.com>,
        Evgeniy Stepanov <eugenis@...gle.com>,
        Lee Smith <Lee.Smith@....com>,
        Ramana Radhakrishnan <Ramana.Radhakrishnan@....com>,
        Jacob Bramley <Jacob.Bramley@....com>,
        Ruben Ayrapetyan <Ruben.Ayrapetyan@....com>,
        Chintan Pandya <cpandya@...eaurora.org>,
        Luc Van Oostenryck <luc.vanoostenryck@...il.com>,
        Dave Martin <Dave.Martin@....com>,
        Kevin Brodsky <kevin.brodsky@....com>,
        Szabolcs Nagy <Szabolcs.Nagy@....com>, khalid.aziz@...cle.com
Subject: Re: [PATCH v12 00/13] arm64: untag user pointers passed to the kernel

On Tue, Mar 19, 2019 at 11:32:12AM -0700, Andrew Morton wrote:
> On Mon, 18 Mar 2019 18:17:32 +0100 Andrey Konovalov <andreyknvl@...gle.com> wrote:
> > === Notes
> > 
> > This patchset is meant to be merged together with "arm64 relaxed ABI" [3].
> 
> What does this mean, precisely?  That neither series is useful without
> the other?  That either patchset will break things without the other?

This series does the work of relaxing the ABI w.r.t. pointer syscall
arguments for arm64 (while preserving backwards compatibility, we can't
break this). Vincenzo's patches [1] document the ABI relaxation and
introduce an AT_FLAG bit by which user space can check for the presence
of such support. So I'd say [1] goes on top of this series.

Once we agreed on the ABI definition, they should be posted as a single
series.

> Only a small fraction of these patches carry evidence of having been
> reviewed.  Fixable?

That's fixable, though the discussions go back to last summer mostly at
a higher level: are we sure these are the only places that need
patching? The outcome of such discussions was a document clarifying
which pointers user can tag and pass to the kernel based on the origins
of the memory range (e.g. anonymous mmap()).

I'd very much like to get input from the SPARC ADI guys on these series
(cc'ing Khalid). While currently for arm64 that's just a software
feature (the hardware one, MTE - memory tagging extensions, is coming
later), the ADI has similar requirements regarding the user ABI. AFAICT
from the SPARC example code, the user is not allowed to pass a tagged
pointers (non-zero top byte) into the kernel. Feedback from the Google
hwasan guys is that such approach is not practical for a generic
deployment of this feature (e.g. automatic tagging of heap allocations).

> Which maintainer tree would be appropriate for carrying these patches?

Given that the arm64 changes are fairly minimal, the -mm tree works for
me (once I reviewed/acked the patches and, ideally, get the SPARC people
onboard with such approach).

[1] https://lkml.org/lkml/2019/3/18/819

-- 
Catalin