linux-kernel - Re: [PATCH] slub: remove useless kmem_cache_debug() before remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1903191812360.18028@chino.kir.corp.google.com>
Date:   Tue, 19 Mar 2019 18:15:16 -0700 (PDT)
From:   David Rientjes <rientjes@...gle.com>
To:     Liu Xiang <liu.xiang6@....com.cn>
cc:     cl@...ux.com, penberg@...nel.org, iamjoonsoo.kim@....com,
        akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, liuxiang_1999@....com
Subject: Re: [PATCH] slub: remove useless kmem_cache_debug() before
 remove_full()

On Thu, 14 Mar 2019, Liu Xiang wrote:

> When CONFIG_SLUB_DEBUG is not enabled, remove_full() is empty.
> While CONFIG_SLUB_DEBUG is enabled, remove_full() can check
> s->flags by itself. So kmem_cache_debug() is useless and
> can be removed.
> 
> Signed-off-by: Liu Xiang <liu.xiang6@....com.cn>

Acked-by: David Rientjes <rientjes@...gle.com>