linux-kernel - Re: [PATCH] efi: Unify dmi setup code over architectures arm/arm64, io64 and x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190320144828.a7iui7v5cwt45myr@rric.localdomain>
Date:   Wed, 20 Mar 2019 14:48:34 +0000
From:   Robert Richter <rrichter@...vell.com>
To:     Tony Luck <tony.luck@...el.com>, Fenghua Yu <fenghua.yu@...el.com>,
        "Thomas Gleixner" <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "Borislav Petkov" <bp@...en8.de>, "H. Peter Anvin" <hpa@...or.com>,
        "x86@...nel.org" <x86@...nel.org>,
        Jean Delvare <jdelvare@...e.com>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>
CC:     Marcin Benka <mbenka@...vell.com>,
        "linux-ia64@...r.kernel.org" <linux-ia64@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>
Subject: Re: [PATCH] efi: Unify dmi setup code over architectures arm/arm64,
 io64 and x86

On 20.03.19 13:16:13, Robert Richter wrote:

> diff --git a/drivers/firmware/efi/arm-runtime.c b/drivers/firmware/efi/arm-runtime.c
> index 4a0dfe4ab829..c250b767030e 100644
> --- a/drivers/firmware/efi/arm-runtime.c
> +++ b/drivers/firmware/efi/arm-runtime.c
> @@ -162,14 +162,10 @@ void efi_virtmap_unload(void)
>  static int __init arm_dmi_init(void)
>  {
>  	/*
> -	 * On arm64/ARM, DMI depends on UEFI, and dmi_scan_machine() needs to
> +	 * On arm64/ARM, DMI depends on UEFI, and dmi_setup() needs to
>  	 * be called early because dmi_id_init(), which is an arch_initcall
>  	 * itself, depends on dmi_scan_machine() having been called already.
>  	 */
> -	dmi_scan_machine();
> -	dmi_memdev_walk();
> -	if (dmi_available)
> -		dmi_set_dump_stack_arch_desc();

This went wrong in the last stage of a comment rework. A dmi_setup()
should be here. Will resubmit. Sorry.

-Robert

>  	return 0;
>  }