linux-kernel - Re: [PATCH -next] audit: Make audit_log_cap and audit_copy_inode static

Open Source and information security mailing list archives

Message-ID: <20190320152757.qt45w75x2zy3iuv5@madcap2.tricolour.ca>
Date:   Wed, 20 Mar 2019 11:27:58 -0400
From:   Richard Guy Briggs <rgb@...hat.com>
To:     Yue Haibing <yuehaibing@...wei.com>
Cc:     paul@...l-moore.com, eparis@...hat.com, linux-audit@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] audit: Make audit_log_cap and audit_copy_inode
 static

On 2019-03-20 21:59, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@...wei.com>
> 
> Fix sparse warning:
> 
> kernel/auditsc.c:1150:6: warning: symbol 'audit_log_cap' was not declared. Should it be static?
> kernel/auditsc.c:1908:6: warning: symbol 'audit_copy_inode' was not declared. Should it be static?
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Thanks for the patch.

Acked-by: Richard Guy Briggs <rgb@...hat.com>

> ---
>  kernel/auditsc.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/kernel/auditsc.c b/kernel/auditsc.c
> index fa7b804..17b0007 100644
> --- a/kernel/auditsc.c
> +++ b/kernel/auditsc.c
> @@ -1147,7 +1147,8 @@ static void audit_log_execve_info(struct audit_context *context,
>  	kfree(buf_head);
>  }
>  
> -void audit_log_cap(struct audit_buffer *ab, char *prefix, kernel_cap_t *cap)
> +static void audit_log_cap(struct audit_buffer *ab, char *prefix,
> +			  kernel_cap_t *cap)
>  {
>  	int i;
>  
> @@ -1905,8 +1906,9 @@ static inline int audit_copy_fcaps(struct audit_names *name,
>  }
>  
>  /* Copy inode data into an audit_names. */
> -void audit_copy_inode(struct audit_names *name, const struct dentry *dentry,
> -		      struct inode *inode, unsigned int flags)
> +static void audit_copy_inode(struct audit_names *name,
> +			     const struct dentry *dentry,
> +			     struct inode *inode, unsigned int flags)
>  {
>  	name->ino   = inode->i_ino;
>  	name->dev   = inode->i_sb->s_dev;
> -- 
> 2.7.0
> 
> 
> --
> Linux-audit mailing list
> Linux-audit@...hat.com
> https://www.redhat.com/mailman/listinfo/linux-audit

- RGB

--
Richard Guy Briggs <rgb@...hat.com>
Sr. S/W Engineer, Kernel Security, Base Operating Systems
Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives