linux-kernel - RE: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR10MB2352C3A55BE8FABAF3B02681FE410@VI1PR10MB2352.EURPRD10.PROD.OUTLOOK.COM>
Date:   Wed, 20 Mar 2019 16:03:40 +0000
From:   Steve Twiss <stwiss.opensource@...semi.com>
To:     Fabio Estevam <festevam@...il.com>
CC:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        DEVICETREE <devicetree@...r.kernel.org>,
        LINUX-ARM-KERNEL <linux-arm-kernel@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Support Opensource <Support.Opensource@...semi.com>
Subject: RE: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use
 rgmii-id

Hi Fabio,

On 20 March 2019 12:17, Fabio Estevam wrote:
> Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id
> 
> Hi Steve,
> 
> On Wed, Mar 20, 2019 at 9:06 AM Steve Twiss
> <stwiss.opensource@...semi.com> wrote:
> >
> > The PHY used on the Freescale i.MX6Q/DL SABRE boards is qualified as
> > 'rgmii' instead of 'rgmii-id'. Meaning the RX and TX delays that were
> 
> This patch declares it as 'rgmii-id', which contradicts the commit log.

The PHY used on the Freescale i.MX6Q/DL SABRE boards is qualified as
'rgmii' instead of 'rgmii-id'.

Can that be read two ways?
I meant the phy-mode is currently qualified as 'rgmii' instead of what it
should be: 'rgmii-id'.

[...]

> > This patch fixes the network problems seen on the Freescale i.MX6Q/DL
> 
> Please provide a Fixes tag. It would be good to know if this fix needs
> to be applied to older kernels.

I didn't put a Fixes tag in because I find this patch fixes v5.1-rc1 (which I see as broken).
But the patch is not needed in v5.0 because I see that as working.
So didn't see the need for a Cc: stable.

Regards,
Steve