linux-kernel - Re: [PATCH] gpio: amd-fch: Fix bogus SPDX identifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4dcdcd9c-e599-5b8a-b628-4b02b7a092a1@metux.net>
Date:   Wed, 20 Mar 2019 17:04:41 +0100
From:   "Enrico Weigelt, metux IT consult" <lkml@...ux.net>
To:     Thomas Gleixner <tglx@...utronix.de>,
        Enrico Weigelt <info@...ux.net>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Darren Hart <dvhart@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>, linux-gpio@...r.kernel.org,
        Greg KH <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] gpio: amd-fch: Fix bogus SPDX identifier

On 19.03.19 15:28, Thomas Gleixner wrote:
> spdxcheck.py complains:
> 
>  include/linux/platform_data/gpio/gpio-amd-fch.h: 1:28 Invalid License ID: GPL+
> 
> which is correct because GPL+ is not a valid identifier. Of course this
> could have been caught by checkpatch.pl _before_ submitting or merging the
> patch.
> 
>  WARNING: 'SPDX-License-Identifier: GPL+ */' is not supported in LICENSES/...
>  #271: FILE: include/linux/platform_data/gpio/gpio-amd-fch.h:1:
>  +/* SPDX-License-Identifier: GPL+ */
> 
> Fix it under the assumption that the author meant GPL-2.0+, which makes
> sense as the corresponding C file is using that identifier.

Your assumption is correct.

Acked-By: Enrico Weigelt <info@...ux.net>

I just wonder, why checkpatch.pl didn't bleat me.

Thanks for the fix.


--mtx


-- 
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@...ux.net -- +49-151-27565287