linux-kernel - Re: printk_ratelimited() && proc/sys/kernel/printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190320174804.GF21673@redhat.com>
Date:   Wed, 20 Mar 2019 18:48:04 +0100
From:   Oleg Nesterov <oleg@...hat.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Ingo Molnar <mingo@...nel.org>,
        Steffen Froemer <sfroemer@...hat.com>,
        Linux List Kernel Mailing <linux-kernel@...r.kernel.org>
Subject: Re: printk_ratelimited() && proc/sys/kernel/printk_ratelimit*

On 03/20, Linus Torvalds wrote:
>
> On Wed, Mar 20, 2019 at 10:03 AM Oleg Nesterov <oleg@...hat.com> wrote:
> >
> > At the same time, printk_ratelimited() uses a static ratelimit_state, so user-
> > space can't override the default DEFAULT_RATELIMIT_.* numbers.
> >
> > Isn't it strange? Shouldn't printk_ratelimited() use printk_ratelimit_state ?
>
> No it shouldn't.
>
> Each printk_ratelimited() is independent, and that's very much on purpose.

Damn, I am really stupid.

Oleg.