linux-kernel - Re: [PATCH 0/8]: blk-mq: use static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5879cad9-9d47-4690-0f85-00835346029b@grimberg.me>
Date:   Wed, 20 Mar 2019 11:38:30 -0700
From:   Sagi Grimberg <sagi@...mberg.me>
To:     Keith Busch <kbusch@...nel.org>,
        Bart Van Assche <bvanassche@....org>
Cc:     axboe@...nel.dk, keith.busch@...el.com, jsmart2021@...il.com,
        josef@...icpanda.com, linux-nvme@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
        hare@...e.de, "jianchao.wang" <jianchao.w.wang@...cle.com>,
        jthumshirn@...e.de, hch@....de
Subject: Re: [PATCH 0/8]: blk-mq: use static_rqs to iterate busy tags


>> Hi Jianchao,
>>
>> I think that's an additional reason to rewrite NVMe error handling ...
> 
> Nonesense. Block timeout handling runs in a work queue precicesly so
> handlers can actually do useful work in line with the notification.

I have to agree with Keith on this one, there is absolutely no reason to
force this constraint on the error handler. If we want to teardown stuff
to guarantee that we can free the request safely we may very well need
to block on queue flushing.