linux-kernel - [PATCH] mfd: cros_ec: Only register a positive IRQ number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190321210347.34793-1-egranata@chromium.org>
Date:   Thu, 21 Mar 2019 14:03:47 -0700
From:   egranata@...omium.org
To:     lee.jones@...aro.org, bleung@...omium.org,
        enric.balletbo@...labora.com, groeck@...omium.org,
        linux-kernel@...r.kernel.org
Cc:     gwendal@...gle.com, amstan@...gle.com, egranata@...omium.org
Subject: [PATCH] mfd: cros_ec: Only register a positive IRQ number

From: Enrico Granata <egranata@...omium.org>

Add a layer of sanity checking to cros_ec_register against attempting to
register IRQ values that are not strictly greater than 0.

Signed-off-by: Enrico Granata <egranata@...omium.org>
---
 drivers/mfd/cros_ec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
index 6acfe036d5222..ff8984a2b8c21 100644
--- a/drivers/mfd/cros_ec.c
+++ b/drivers/mfd/cros_ec.c
@@ -118,7 +118,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev)
 		return err;
 	}
 
-	if (ec_dev->irq) {
+	if (ec_dev->irq > 0) {
 		err = devm_request_threaded_irq(dev, ec_dev->irq, NULL,
 				ec_irq_thread, IRQF_TRIGGER_LOW | IRQF_ONESHOT,
 				"chromeos-ec", ec_dev);
-- 
2.21.0.225.g810b269d1ac-goog