lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 22 Mar 2019 00:26:18 +0100 From: "Rafael J. Wysocki" <rjw@...ysocki.net> To: David Arcari <darcari@...hat.com> Cc: linux-pm@...r.kernel.org, Len Brown <len.brown@...el.com>, Jirka Hladky <jhladky@...hat.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH] tools/power turbostat: return the exit status of a command On Tuesday, February 12, 2019 3:34:39 PM CET David Arcari wrote: > turbostat failed to return a non-zero exit status even though the > supplied command (turbostat <command>) failed. Currently when turbostat > forks a command it returns zero instead of the actual exit status of the > command. Modify the code to return the exit status. > > Signed-off-by: David Arcari <darcari@...hat.com> > Cc: Len Brown <len.brown@...el.com> > Cc: Jirka Hladky <jhladky@...hat.com> > Cc: linux-kernel@...r.kernel.org > --- > tools/power/x86/turbostat/turbostat.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c > index 9327c0d..c3fad06 100644 > --- a/tools/power/x86/turbostat/turbostat.c > +++ b/tools/power/x86/turbostat/turbostat.c > @@ -5077,6 +5077,9 @@ int fork_it(char **argv) > signal(SIGQUIT, SIG_IGN); > if (waitpid(child_pid, &status, 0) == -1) > err(status, "waitpid"); > + > + if (WIFEXITED(status)) > + status = WEXITSTATUS(status); > } > /* > * n.b. fork_it() does not check for errors from for_all_cpus() > Applied, thanks!
Powered by blists - more mailing lists