linux-kernel - Re: [PATCH v2] staging: rtlwifi: Fix potential NULL pointer dereference of kzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190321072039.GI2202@kadam>
Date:   Thu, 21 Mar 2019 10:20:40 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Aditya Pakki <pakki001@....edu>
Cc:     devel@...verdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Nathan Chancellor <natechancellor@...il.com>, kjlu@....edu,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: rtlwifi: Fix potential NULL pointer
 dereference of kzalloc

On Tue, Mar 19, 2019 at 03:15:08PM -0500, Aditya Pakki wrote:
> phydm.internal is allocated using kzalloc which is used multiple
> times without a check for NULL pointer. This patch avoids such a
> scenario.
> 
> --
> v1: Patch collision with different things, fix as per Greg
> Signed-off-by: Aditya Pakki <pakki001@....edu>
> ---

Gar...  Sorry, no, that's not quite right.  It should be:

blah blah blah...

Signed-off-by: you
---
V1: Patch collision with different things, fix as per Greg

Try applying your patch with `cat raw_email.txt | git am` and you'll see
the problem with the commit message.

regards,
dan carpenter