linux-kernel - Re: [PATCH v4 4/4] leds: lm3532: Introduce the lm3532 LED driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190321082139.GS4731@dell>
Date:   Thu, 21 Mar 2019 08:21:39 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Dan Murphy <dmurphy@...com>
Cc:     Jacek Anaszewski <jacek.anaszewski@...il.com>, robh+dt@...nel.org,
        pavel@....cz, tony@...mide.com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org
Subject: Re: [PATCH v4 4/4] leds: lm3532: Introduce the lm3532 LED driver

On Wed, 20 Mar 2019, Dan Murphy wrote:
> On 3/20/19 1:59 PM, Jacek Anaszewski wrote:
> > On 3/13/19 1:32 PM, Dan Murphy wrote:
> >> Introduce the Texas Instruments LM3532 White LED driver.
> >> The driver supports ALS configurability or manual brightness
> >> control.
> >>
> >> The driver also supports associating LED strings with specific
> >> control banks in a group or as individually controlled strings.
> >>
> >> Signed-off-by: Dan Murphy <dmurphy@...com>
> >> ---
> >>
> >> v4 - Updated code to DT doc changes appending "ti," to TI specific properties -
> >> https://lore.kernel.org/patchwork/patch/1050124/
> >>
> >> v3 - Removed switch case for register setting in favor of an algorithim (v1 comment),
> >> https://lore.kernel.org/patchwork/patch/1049024/
> >> v2 - Added look up tables for als_avg, als_imp and ramp times, fixed brightness
> >> control when ALS is in control, added property value checks to ensure the values
> >> are not out of bounds - https://lore.kernel.org/patchwork/patch/1048807/
> >>
> >>   drivers/leds/Kconfig       |  10 +
> >>   drivers/leds/Makefile      |   1 +
> >>   drivers/leds/leds-lm3532.c | 681 +++++++++++++++++++++++++++++++++++++
> >>   3 files changed, 692 insertions(+)
> >>   create mode 100644 drivers/leds/leds-lm3532.c

[snip 700 lines of churn]

> Ack.  I give post v5 tomorrow.

Same for you too please Dan.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog