lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <tip-0c671812f152b628bd87c0af49da032cc2a2c319@git.kernel.org>
Date:   Thu, 21 Mar 2019 04:07:04 -0700
From:   tip-bot for Josh Poimboeuf <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     mingo@...nel.org, hpa@...or.com, peterz@...radead.org,
        linux-kernel@...r.kernel.org, tglx@...utronix.de,
        moosotc@...il.com, jpoimboe@...hat.com
Subject: [tip:core/urgent] objtool: Move objtool_file struct off the stack

Commit-ID:  0c671812f152b628bd87c0af49da032cc2a2c319
Gitweb:     https://git.kernel.org/tip/0c671812f152b628bd87c0af49da032cc2a2c319
Author:     Josh Poimboeuf <jpoimboe@...hat.com>
AuthorDate: Mon, 18 Mar 2019 19:09:38 -0500
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Thu, 21 Mar 2019 12:02:19 +0100

objtool: Move objtool_file struct off the stack

Objtool uses over 512k of stack, thanks to the hash table embedded in
the objtool_file struct.  This causes an unnecessarily large stack
allocation and breaks users with low stack limits.

Move the struct off the stack.

Fixes: 042ba73fe7eb ("objtool: Add several performance improvements")
Reported-by: Vassili Karpov <moosotc@...il.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: stable@...r.kernel.org
Link: https://lkml.kernel.org/r/df92dcbc4b84b02ffa252f46876df125fb56e2d7.1552954176.git.jpoimboe@redhat.com

---
 tools/objtool/check.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index 0414a0d52262..5dde107083c6 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -2184,9 +2184,10 @@ static void cleanup(struct objtool_file *file)
 	elf_close(file->elf);
 }
 
+static struct objtool_file file;
+
 int check(const char *_objname, bool orc)
 {
-	struct objtool_file file;
 	int ret, warnings = 0;
 
 	objname = _objname;

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ