linux-kernel - Re: [PATCH -next] ipmi: Make ipmi_interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190321122744.GD2628@minyard.net>
Date:   Thu, 21 Mar 2019 07:27:44 -0500
From:   Corey Minyard <minyard@....org>
To:     Yue Haibing <yuehaibing@...wei.com>
Cc:     cminyard@...sta.com, arnd@...db.de, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org,
        openipmi-developer@...ts.sourceforge.net
Subject: Re: [PATCH -next] ipmi: Make ipmi_interfaces_srcu variable static

On Wed, Mar 20, 2019 at 09:35:05PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@...wei.com>
> 
> Fix sparse warning:
> 
> drivers/char/ipmi/ipmi_msghandler.c:635:20: warning:
>  symbol 'ipmi_interfaces_srcu' was not declared. Should it be static?

Queued for Linux 5.1.   Thanks

-corey

> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/char/ipmi/ipmi_msghandler.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
> index c35f2bc..7ebdde4 100644
> --- a/drivers/char/ipmi/ipmi_msghandler.c
> +++ b/drivers/char/ipmi/ipmi_msghandler.c
> @@ -632,7 +632,7 @@ static DEFINE_MUTEX(ipmidriver_mutex);
>  
>  static LIST_HEAD(ipmi_interfaces);
>  static DEFINE_MUTEX(ipmi_interfaces_mutex);
> -struct srcu_struct ipmi_interfaces_srcu;
> +static struct srcu_struct ipmi_interfaces_srcu;
>  
>  /*
>   * List of watchers that want to know when smi's are added and deleted.
> -- 
> 2.7.0
> 
>