linux-kernel - Re: [PATCH] drivers: ufs: Add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 21 Mar 2019 14:21:06 +0100
From:   Anders Roxell <anders.roxell@...aro.org>
To:     Stanley Chu <stanley.chu@...iatek.com>
Cc:     jejb@...ux.ibm.com, martin.petersen@...cle.com,
        Matthias Brugger <matthias.bgg@...il.com>,
        linux-scsi@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        linux-mediatek@...ts.infradead.org, peter.wang@...iatek.com
Subject: Re: [PATCH] drivers: ufs: Add missing MODULE_* information

On Thu, 21 Mar 2019 at 14:18, Stanley Chu <stanley.chu@...iatek.com> wrote:
>
> Hi Anders,
>
> On Thu, 2019-03-21 at 13:50 +0100, Anders Roxell wrote:
> > When building the ufs-mediatek module the following warning shows up:
> >
> > WARNING: modpost: missing MODULE_LICENSE() in
> >   drivers/scsi/ufs/ufs-mediatek.o
> >
> > Rework to add MODULE_LICENSE,MODULE_AUTHOR and MODULE_DESCRIPTION.
> >
> > Fixes: ddd90623ce26 ("scsi: ufs-mediatek: Add UFS support for Mediatek SoC chips")
> > Signed-off-by: Anders Roxell <anders.roxell@...aro.org>
> > ---
> >  drivers/scsi/ufs/ufs-mediatek.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
> > index c3b78fc83d3f..ce4767784937 100644
> > --- a/drivers/scsi/ufs/ufs-mediatek.c
> > +++ b/drivers/scsi/ufs/ufs-mediatek.c
> > @@ -364,4 +364,9 @@ static struct platform_driver ufs_mtk_pltform = {
> >       },
> >  };
> >
> > +MODULE_AUTHOR("Stanley Chu <stanley.chu@...iatek.com>");
> > +MODULE_AUTHOR("Peter Wang <peter.wang@...iatek.com>");
> > +MODULE_DESCRIPTION("Mediatek UFS Driver");
>
> Thanks for sending this.
>
> Could you fix it as "MediaTek UFS Host Driver" ?

Yes, I'll update it and sending out a v2 shortly.

Cheers,
Anders

>
> > +MODULE_LICENSE("GPL v2");
> > +
> >  module_platform_driver(ufs_mtk_pltform);
>
> Thanks,
> Stanley
>