linux-kernel - Re: [PATCH -next] drm/ttm: remove set but not used variable 'rdev'

Open Source and information security mailing list archives

Message-ID: <CADnq5_OS8SkHxFp41u_BwQRMZAr+3KHACRndSn+bROnMPQE9JA@mail.gmail.com>
Date:   Thu, 21 Mar 2019 10:00:02 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     "Deucher, Alexander" <alexander.deucher@....com>,
        Christian Koenig <christian.koenig@....com>,
        Chunming Zhou <David1.Zhou@....com>,
        Dave Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        kernel-janitors@...r.kernel.org,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] drm/ttm: remove set but not used variable 'rdev'

On Wed, Mar 20, 2019 at 9:25 AM YueHaibing <yuehaibing@...wei.com> wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/radeon/radeon_ttm.c: In function 'radeon_move_vram_ram':
> drivers/gpu/drm/radeon/radeon_ttm.c:254:24: warning:
>  variable 'rdev' set but not used [-Wunused-but-set-variable]
>
> drivers/gpu/drm/radeon/radeon_ttm.c: In function 'radeon_move_ram_vram':
> drivers/gpu/drm/radeon/radeon_ttm.c:301:24: warning:
>  variable 'rdev' set but not used [-Wunused-but-set-variable]
>
> It's not used since a987fcaa805f ("ttm: Make parts of a struct ttm_bo_device
> global.")
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Applied.  thanks!

Alex

> ---
>  drivers/gpu/drm/radeon/radeon_ttm.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index 557bdd7a2fc8..5d42f8d8e68d 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -251,14 +251,12 @@ static int radeon_move_vram_ram(struct ttm_buffer_object *bo,
>                                 struct ttm_mem_reg *new_mem)
>  {
>         struct ttm_operation_ctx ctx = { interruptible, no_wait_gpu };
> -       struct radeon_device *rdev;
>         struct ttm_mem_reg *old_mem = &bo->mem;
>         struct ttm_mem_reg tmp_mem;
>         struct ttm_place placements;
>         struct ttm_placement placement;
>         int r;
>
> -       rdev = radeon_get_rdev(bo->bdev);
>         tmp_mem = *new_mem;
>         tmp_mem.mm_node = NULL;
>         placement.num_placement = 1;
> @@ -298,14 +296,12 @@ static int radeon_move_ram_vram(struct ttm_buffer_object *bo,
>                                 struct ttm_mem_reg *new_mem)
>  {
>         struct ttm_operation_ctx ctx = { interruptible, no_wait_gpu };
> -       struct radeon_device *rdev;
>         struct ttm_mem_reg *old_mem = &bo->mem;
>         struct ttm_mem_reg tmp_mem;
>         struct ttm_placement placement;
>         struct ttm_place placements;
>         int r;
>
> -       rdev = radeon_get_rdev(bo->bdev);
>         tmp_mem = *new_mem;
>         tmp_mem.mm_node = NULL;
>         placement.num_placement = 1;
>
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives