linux-kernel - RE: [PATCH 1/3] ASoC: da7219: Update DAI clock binding info to cover WCLK/BCLK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM5PR1001MB0994B0B76F0166D45990E5F980420@AM5PR1001MB0994.EURPRD10.PROD.OUTLOOK.COM>
Date:   Thu, 21 Mar 2019 14:15:41 +0000
From:   Adam Thomson <Adam.Thomson.Opensource@...semi.com>
To:     Mark Brown <broonie@...nel.org>,
        Adam Thomson <Adam.Thomson.Opensource@...semi.com>
CC:     Liam Girdwood <lgirdwood@...il.com>, Takashi Iwai <tiwai@...e.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Akshu Agrawal <Akshu.Agrawal@....com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Support Opensource <Support.Opensource@...semi.com>
Subject: RE: [PATCH 1/3] ASoC: da7219: Update DAI clock binding info to cover
 WCLK/BCLK

On 21 March 2019 12:22, Mark Brown wrote:

> On Tue, Mar 19, 2019 at 05:49:30PM +0000, Adam Thomson wrote:
> 
> > -- #clock-cells :  Should be set to '<0>', only one clock source
> > provided;
> > -- clock-output-names : Name given for DAI clocks output;
> > +- #clock-cells :  Should be set to '<1>', two clock sources provided;
> > +- clock-output-names : Names given for DAI clock outputs (WCLK &
> > +BCLK);
> 
> This might need some handling later on as it's a binding change, however I can't
> see any current users so hopefully nobody will notice.

No I do not believe there are users of this, other than the AMD board which
doesn't use these bindings. Actually given they're the same bindings, albeit
with a different number of cells, I've tested the code with just 1 cell and
1 clock in the DTS and this still works as before so the driver should be
backwards compatible.