linux-kernel - Re: [PATCH 2/2] arm64: dts: rockchip: fix cts, rts pin assign of UART3 for rk3399

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d085cb23-68f2-ecb4-9421-99389335a78f@katsuster.net>
Date:   Thu, 21 Mar 2019 23:55:36 +0900
From:   Katsuhiro Suzuki <katsuhiro@...suster.net>
To:     Heiko Stuebner <heiko@...ech.de>,
        linux-rockchip@...ts.infradead.org
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: fix cts, rts pin assign of
 UART3 for rk3399

ping again...

Please let me know if there is problem in this patch.


On 2019/03/04 23:00, Katsuhiro Suzuki wrote:
> ping...
> 
> On 2019/02/19 23:08, Katsuhiro Suzuki wrote:
>> This patch fixes pin assign of cts and rts signal of UART3.
>>
>> Currently GPIO3_C2 and C3 pins are assigned but TRM says that
>> GPIO3_C0 and C1 are correct.
>>
>> Refer:
>>    RK3399 TRM v1.4 - Table 19-1 UART Interface Description
>>
>> Signed-off-by: Katsuhiro Suzuki <katsuhiro@...suster.net>
>> ---
>>   arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi 
>> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> index 76fc2c7af80a..beaa92744a64 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> @@ -2535,12 +2535,12 @@
>>               uart3_cts: uart3-cts {
>>                   rockchip,pins =
>> -                    <3 RK_PC2 RK_FUNC_2 &pcfg_pull_none>;
>> +                    <3 RK_PC0 RK_FUNC_2 &pcfg_pull_none>;
>>               };
>>               uart3_rts: uart3-rts {
>>                   rockchip,pins =
>> -                    <3 RK_PC3 RK_FUNC_2 &pcfg_pull_none>;
>> +                    <3 RK_PC1 RK_FUNC_2 &pcfg_pull_none>;
>>               };
>>           };
>>
> 
>