linux-kernel - Re: [PATCH -next] phy: tegra: xusb: fix typo in tegra186_usb2_pad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 21 Mar 2019 16:05:37 +0100
From:   Thierry Reding <thierry.reding@...il.com>
To:     Wei Yongjun <weiyongjun1@...wei.com>
Cc:     JC Kuo <jckuo@...dia.com>, Kishon Vijay Abraham I <kishon@...com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH -next] phy: tegra: xusb: fix typo in
 tegra186_usb2_pad_probe()

On Thu, Mar 21, 2019 at 08:54:36AM +0000, Wei Yongjun wrote:
> Fix a typo in tegra186_usb2_pad_probe(), 'usb2->clk' should be
> 'priv->usb2_trk_clk'.
> 
> Fixes: b8998e928030 ("phy: tegra: xusb: Add Tegra186 support")
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  drivers/phy/tegra/xusb-tegra186.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Good catch!

Acked-by: Thierry Reding <treding@...dia.com>

> 
> diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/xusb-tegra186.c
> index 11ad6e4e4711..a627fe0b8e54 100644
> --- a/drivers/phy/tegra/xusb-tegra186.c
> +++ b/drivers/phy/tegra/xusb-tegra186.c
> @@ -467,8 +467,8 @@ tegra186_usb2_pad_probe(struct tegra_xusb_padctl *padctl,
>  	}
>  
>  	priv->usb2_trk_clk = devm_clk_get(&pad->dev, "trk");
> -	if (IS_ERR(usb2->clk)) {
> -		err = PTR_ERR(usb2->clk);
> +	if (IS_ERR(priv->usb2_trk_clk)) {
> +		err = PTR_ERR(priv->usb2_trk_clk);
>  		dev_dbg(&pad->dev, "failed to get usb2 trk clock: %d\n", err);
>  		goto unregister;
>  	}
> 
> 
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)