linux-kernel - Re: [PATCH v2] EDAC, mellanox: Add ECC support for BlueField DDR4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cb7939d0-2723-7d8c-2f9f-03c24f0cef77@infradead.org>
Date:   Thu, 21 Mar 2019 08:23:23 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Junhan Zhou <Junhan@...lanox.com>, Borislav Petkov <bp@...en8.de>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     Liming Sun <lsun@...lanox.com>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] EDAC, mellanox: Add ECC support for BlueField DDR4

On 3/21/19 7:30 AM, Junhan Zhou wrote:
>>> +config EDAC_BLUEFIELD
>>> +	tristate "Mellanox BlueField Memory ECC"
>>> +	depends on (MELLANOX_PLATFORM && ARM64 && ACPI) ||
>> COMPILE_TEST
>>
>> Hi,
>>
>> While I am in favor of using COMPILE_TEST whenever possible, I don't see
>> how that is possible here if:
>>
>> # MELLANOX_PLATFORM is not set
>> # ARM64 is not set
>> # ACPI is not set
>> COMPILE_TEST=y
>>
>> Can you please explain?
>>
>> Thanks.
>>
>> ~Randy
> 
> Good point. I tried compiling it against the x86 architecture and it fails because it can't find the definition for arm_smccc_smc(). But it would compile for the ARM64 architecture with both ACPI and MELLANOX _PLATFORM not set, so I'll change it to ARM64 && ((MELLANOX_PLATFORM && ACPI) || COMPILE_TEST) instead.
> The dependency on ACPI is because our BlueField SoC firmware only uses ACPI to pass the device mappings, and MELLANOX_PLATFORM because this device is only seen on the Mellanox BlueField SoC so it would be pointless to be used elsewhere, but these doesn't prevent it from being compiled.
> 
> -Junhan
> 

Sounds fine.  Thanks.

-- 
~Randy