linux-kernel - [PATCH v1] lib/generic-radix-tree: Make good use of while (level--)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Mar 2019 18:30:36 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Kent Overstreet <kent.overstreet@...il.com>,
        linux-kernel@...r.kernel.org
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: [PATCH v1] lib/generic-radix-tree: Make good use of while (level--)

There is no need to split postincrement in while (level--) type of loops.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
---
 lib/generic-radix-tree.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/lib/generic-radix-tree.c b/lib/generic-radix-tree.c
index a7bafc413730..5a1818a0de1f 100644
--- a/lib/generic-radix-tree.c
+++ b/lib/generic-radix-tree.c
@@ -59,13 +59,9 @@ void *__genradix_ptr(struct __genradix *radix, size_t offset)
 	if (ilog2(offset) >= genradix_depth_shift(level))
 		return NULL;
 
-	while (1) {
+	while (level--) {
 		if (!n)
 			return NULL;
-		if (!level)
-			break;
-
-		level--;
 
 		n = n->children[offset >> genradix_depth_shift(level)];
 		offset &= genradix_depth_size(level) - 1;
@@ -157,9 +153,7 @@ void *__genradix_iter_peek(struct genradix_iter *iter,
 	if (ilog2(iter->offset) >= genradix_depth_shift(level))
 		return NULL;
 
-	while (level) {
-		level--;
-
+	while (level--) {
 		i = (iter->offset >> genradix_depth_shift(level)) &
 			(GENRADIX_ARY - 1);
 
-- 
2.20.1