linux-kernel - Re: [PATCH] spi: export tracepoint symbols to modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190321154924.e5naj2bpdxp7krjb@pengutronix.de>
Date:   Thu, 21 Mar 2019 16:49:24 +0100
From:   Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Mark Brown <broonie@...nel.org>,
        Boris Brezillon <bbrezillon@...nel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: export tracepoint symbols to modules

On Thu, Mar 21, 2019 at 01:42:25PM +0100, Arnd Bergmann wrote:
> The newly added tracepoints in the spi-mxs driver cause a link
> error when the driver is a loadable module:
> 
> ERROR: "__tracepoint_spi_transfer_stop" [drivers/spi/spi-mxs.ko] undefined!
> ERROR: "__tracepoint_spi_transfer_start" [drivers/spi/spi-mxs.ko] undefined!
> 
> I'm not quite sure where to put the export statements, but
> directly after the inclusion of the header seems as good as
> any other place.

I agree it looks a bit ugly, but I don't have a better idea either.
> 
> Fixes: f3fdea3af405 ("spi: mxs: add tracing to custom .transfer_one_message callback")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Looks right:

Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

Thanks for finding and fixing that.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |