linux-kernel - Re: [PATCH 050/114] net: Kconfig: pedantic formatting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Mar 2019 11:10:43 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     "Enrico Weigelt, metux IT consult" <info@...ux.net>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 050/114] net: Kconfig: pedantic formatting

On Mon, Mar 11, 2019 at 10:26 PM Enrico Weigelt, metux IT consult
<info@...ux.net> wrote:
>
> Formatting of Kconfig files doesn't look so pretty, so let the
> Great White Handkerchief come around and clean it up.
>
> Signed-off-by: Enrico Weigelt, metux IT consult <info@...ux.net>
> ---
>  net/Kconfig                 |  14 +--
>  net/batman-adv/Kconfig      |  10 +-
>  net/bluetooth/Kconfig       |   2 +-
>  net/ife/Kconfig             |   2 +-
>  net/ipv4/Kconfig            | 231 ++++++++++++++++++++++----------------------
>  net/ipv4/netfilter/Kconfig  |   4 +-
>  net/ipv6/netfilter/Kconfig  |  26 ++---
>  net/mpls/Kconfig            |  10 +-
>  net/netfilter/Kconfig       |  10 +-
>  net/netfilter/ipset/Kconfig |   2 +-
>  net/netfilter/ipvs/Kconfig  |  68 ++++++-------
>  net/nfc/hci/Kconfig         |  14 +--
>  net/rds/Kconfig             |   4 +-
>  net/sched/Kconfig           | 130 ++++++++++++-------------
>  net/wireless/Kconfig        |  38 ++++----
>  net/xfrm/Kconfig            |  10 +-
>  16 files changed, 287 insertions(+), 288 deletions(-)
>

>
>  config TCP_CONG_NV
> -       tristate "TCP NV"
> -       default n
> -       ---help---
> -       TCP NV is a follow up to TCP Vegas. It has been modified to deal with
> -       10G networks, measurement noise introduced by LRO, GRO and interrupt
> -       coalescence. In addition, it will decrease its cwnd multiplicatively
> -       instead of linearly.
> +       tristate "TCP NV"
> +       default n
> +       ---help---

You are touching this line,
so i want you to replace it to 'help' to fix checkpatch.pl warning.


WARNING: prefer 'help' over '---help---' for new help texts
#560: FILE: net/ipv4/Kconfig:560:
+config TCP_CONG_NV



> +         TCP NV is a follow up to TCP Vegas. It has been modified to deal with
> +         10G networks, measurement noise introduced by LRO, GRO and interrupt
> +         coalescence. In addition, it will decrease its cwnd multiplicatively
> +         instead of linearly.
>
> -       Note that in general congestion avoidance (cwnd decreased when # packets
> -       queued grows) cannot coexist with congestion control (cwnd decreased only
> -       when there is packet loss) due to fairness issues. One scenario when they
> -       can coexist safely is when the CA flows have RTTs << CC flows RTTs.
> +         Note that in general congestion avoidance (cwnd decreased when # packets
> +         queued grows) cannot coexist with congestion control (cwnd decreased only
> +         when there is packet loss) due to fairness issues. One scenario when they
> +         can coexist safely is when the CA flows have RTTs << CC flows RTTs.
>
> -       For further details see http://www.brakmo.org/networking/tcp-nv/
> +         For further details see http://www.brakmo.org/networking/tcp-nv/
>




-- 
Best Regards
Masahiro Yamada