[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20190321185432.GA18568@kroah.com>
Date: Thu, 21 Mar 2019 19:54:32 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Bharath Vedartham <linux.bhar@...il.com>
Cc: devel@...verdev.osuosl.org, christian@...mp.de,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: ralink-gdma: Prefer u32 over uint32_t
On Fri, Mar 22, 2019 at 12:18:58AM +0530, Bharath Vedartham wrote:
> On Thu, Mar 21, 2019 at 07:46:09PM +0100, Greg KH wrote:
> > On Fri, Mar 22, 2019 at 12:07:10AM +0530, Bharath Vedartham wrote:
> > > Change uint32_t to u32
> >
> > That says _what_ you did, but _why_ are you doing this? That's the main
> > content a changelog text should have in it.
> >
> > thanks,
> >
> > greg k-h
> That was a checkpatch.pl warning! I forgot to mention that! It fixed a
> checkpatch.pl warning. I ll write better changelogs from my next commit
> on. Thanks for the feedback!
Please fix this up and resend as a "v2" patch, if you wish to have it
accepted.
thanks,
greg k-h
Powered by blists - more mailing lists