linux-kernel - Re: [PATCH] net: macb: Add null check for PCLK and HCLK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190321.132256.242396753611559420.davem@davemloft.net>
Date:   Thu, 21 Mar 2019 13:22:56 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     harini.katakam@...inx.com
Cc:     nicolas.ferre@...rochip.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, michal.simek@...inx.com,
        harinikatakamlinux@...il.com
Subject: Re: [PATCH] net: macb: Add null check for PCLK and HCLK

From: Harini Katakam <harini.katakam@...inx.com>
Date: Wed, 20 Mar 2019 19:12:22 +0530

> Both PCLK and HCLK are "required" clocks according to macb devicetree
> documentation. There is a chance that devm_clk_get doesn't return a
> negative error but just a NULL clock structure instead. In such a case
> the driver proceeds as usual and uses pclk value 0 to calculate MDC
> divisor which is incorrect. Hence fix the same in clock initialization.
> 
> Signed-off-by: Harini Katakam <harini.katakam@...inx.com>

Applied, thanks.